ClickHouse / ClickHouse/clickhouse-rs

Upstream 2 patches, need some guidance

Open
#196 1 comment 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Rust
Stars
559
Forks
172
Avg merge
1d 19h
Merged PRs (30d)
3

Description

Hi,

I would like to upstream 2 patches to keep from carrying them but I would like some guidance on how you want it done as I suspect that either cannot be upstreamed as is:

1) https://github.com/mattklein123/clickhouse.rs/commit/0120dabbb88e88d600718d7166e9df9ddffde6a6. This one is very small but I've found it very useful for debugging. Basically it logs the finalized query after bindings. Since I would imagine you don't want a dependency on log, how might this be done? An optional callback of some kind? Something else?

2) https://github.com/mattklein123/clickhouse.rs/commit/27aea47bc97cca532ab8a2774ea89e7af68f1949. This one allows inserting raw binary data into columns using a new type wrapper. I understand that technically this is a "no no" from the Clickhouse perspective but I use this in production and it's been very useful. I'm not sure if there is a better way to do this but this is the best way I could find.

Please let me know what you think and I can modifying the patches accordingly.

Thanks,
Matt

cc @loyd

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the two linked commits, 0120dabbb88e88d600718d7166e9df9ddde6a6 and 27aea47bc97cca532ab8a2774ea89e7af68f1949, to understand the proposed query logging and raw binary insertion changes. The issue names no files or tests; the work is done only after maintainers decide whether either feature belongs upstream and specify an accepted API.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.