ClickHouse / ClickHouse/clickhouse-java

User Agent is not being added properly to all queries

Open
#2,622 1 comment 0 reactions 0 assignees View on GitHub
bug client-api-v2
Dominant language
Java
Stars
1.6k
Forks
636
Avg merge
2d 16h
Merged PRs (30d)
28

Description

## Description

### Steps to reproduce
1. Create the following table:
```sql
CREATE TABLE default.example_table
(
`id` Int32,
`name` String
)
ENGINE = MergeTree
ORDER BY id
SETTINGS index_granularity = 8192
```
2. Run the following JDBC code:

```java
package com.google.cloud.teleport.v2;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.sql.Connection;
import java.sql.DriverManager;
import java.sql.ResultSet;
import java.sql.SQLException;
import java.sql.Statement;
import java.util.Properties;

public class JDBCMain {
private static final Logger log = LoggerFactory.getLogger(JDBCMain.class);
static final String TABLE_NAME = "default.example_table";

public static void main(String[] args) throws Exception {
String url = System.getProperty("chUrl", "jdbc:ch://localhost:8123?client_name=thisisatest");

// Set user and password if needed
Properties properties = new Properties();
properties.setProperty("user", System.getProperty("chUser", "default"));
properties.setProperty("password", System.getProperty("chPassword", "123456"));

printInsertedData(url, properties);

}

static void printInsertedData(String url, Properties properties) throws SQLException {
try (Connection conn = DriverManager.getConnection(url, properties)) {//Grab a connection using the jdbc DriverManager
try (Statement stmt = conn.createStatement()) {
try (ResultSet rs = stmt.executeQuery("SELECT * FROM " + TABLE_NAME)) {
while (rs.next()) {
//Print the values of the current row
log.info(rs.getString(1));
log.info(rs.getString(2));
}
}
}
}
}

}
```

### Error Log or Exception StackTrace

When querying the `query_log` table, we get the following data. The full result is attached as a CSV.

Image

I verified that all these queries are related to the same "batch".

[jdbc_user_agent_issue.csv](https://github.com/user-attachments/files/23096043/jdbc_user_agent_issue.csv)

### Expected Behaviour

The `client_name` should be applied to all related queries, including internal queries being fired by the client.

#### Client Configuration

Added as a connection string in the example above.

#### Environment
* Client version: 0.9.2

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.