ClickHouse / ClickHouse/clickhouse-go
batch.Send marks batch as sent even there are errors
Open
enhancement
investigate
- Dominant language
- Go
- Stars
- 3.3k
- Forks
- 680
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 14
Description
### Issue description
The `Send` method marks batch as `sent` with any outcome, even if there is some error occurred. There is no way to retry batch sending in case of any issues.
https://github.com/ClickHouse/clickhouse-go/blob/202ca18e6dd39d9720f3fd60530ab1569c78d378/conn_batch.go#L128-L154
Is it an expected behaviour?
### Configuration
*OS:* unrelated
*Interface:* `native`
*Driver version:* v2.0.12 (latest)
*Go version:* unrelated
*ClickHouse Server version:* unrelated
Contributor guide
Assessment
This issue has not been assessed yet.