ClickHouse / ClickHouse/clickhouse-go
OpenTelemetry tracing instrumentation
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 3.3k
- Forks
- 684
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 14
Description
Discussed in https://github.com/ClickHouse/clickhouse-go/discussions/1267
Originally posted by tanenbaum April 9, 2024
Hello!
I was looking at how I might get instrumentation out of the library, both traces and metrics. I noticed that the ch-go "low level" API instruments various code paths, like https://github.com/ClickHouse/ch-go/blob/main/query.go#L609. I did at first think this library used those code paths, but as far as I can tell it is only sharing the driver.Conn interface definition and not using the ch-go client.
Is there any plan to do the same sort of instrumentation in this library? Would you like contributions in this area?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with discussion 1267 and compare the instrumentation example in ch-go/query.go around line 609 with the clickhouse-go driver paths. Determine which tracing and metrics scope the project wants and how completion would be verified; the issue does not yet define an implementation target or acceptance criteria.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100