ClickHouse / ClickHouse/clickhouse-cpp

Remove deprecated headers/functions/options in 3.0

Open
#251 0 comments 0 reactions 1 assignee Claimed by @Enmk View on GitHub
3.0
Dominant language
C
Stars
382
Forks
209
Avg merge
3h 58m
Merged PRs (30d)
12

Description

- [`FromString` and entire header](https://github.com/ClickHouse/clickhouse-cpp/blob/master/clickhouse/base/string_utils.h)
Since it is not used anywhere in the project.

- [`ClientOptions::backward_compatibility_lowcardinality_as_wrapped_column`](https://github.com/ClickHouse/clickhouse-cpp/blob/master/clickhouse/client.h#L99)
Since it was initially introduced as a temporary thing (1.5 years ago), also it makes code uglier and not all cases of `LowCardinality(X)` is supported with that setting `ON`.

- [`StringView` and entire header](https://github.com/ClickHouse/clickhouse-cpp/blob/master/clickhouse/base/string_view.h)
Since the project now requires C++17 which provides `std::string_view`.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.