ClickHouse / ClickHouse/click-ui

Improve typing for `component` prop in components that accept it

Open
#666 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
135
Forks
33
Avg merge
2d 13h
Merged PRs (30d)
19

Description

I spent... some time trying to parse it
I don't think this does what you intended to do
`keyof T` is properties of a string in case of T being a tagname. Or it's `never` if you pass `typeof Component`.

So copilot is wrong by saying `keyof T` includes all component prop keys. But it doesn't contain anything useful either.

I believe you do want to use keyof `GridContainerProps` instead of `keyof T` here

_Originally posted by @ariser in https://github.com/ClickHouse/click-ui/pull/663#discussion_r2303876935_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.