ClickHouse / ClickHouse/click-ui

[Bug]: Pagination component should not switch to column layout at small screen widths

Open
#1,008 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
TypeScript
Stars
135
Forks
33
Avg merge
2d 13h
Merged PRs (30d)
19

Description

### What happened?

The Pagination component's outer Container uses `isResponsive={true}` by default, which causes it to switch from `flex-direction: row` to `flex-direction: column` at ≤768px. This breaks the layout because:

1. The `justify-content: space-between` that spaces "X rows" and the page navigation apart on the horizontal axis stops working, it now applies vertically.
2. Items center horizontally instead of spreading apart, and the page input stretches.
3. The inner nav controls (prev/next buttons, page input) are already designed to stay compact (`fillWidth={false}`, `maxWidth="50px"` on the input), so the column stacking doesn't improve usability.

Expected behavior: The pagination row should maintain its horizontal layout at all screen widths, with "X rows" on the left and page navigation on the right.

Suggested fix: Pass `isResponsive={false}` to the outer `Container` in `Pagination.tsx` so it always stays as a row.

### Component(s) affected

Pagination

### How to reproduce

1. Use a pagination component
2. Minimize the screen so the smallest media query activates

### Click UI Version

current

### Browser(s)

Chrome

### Operating system

macOS

### Is this a regression?

No, never worked as far as I know

### Last working version (if regression)

_No response_

### Screenshots or recording

Image

### Visual / UX checklist

- [ ] Checked in both light and dark mode (if applicable)
- [ ] Checked at different viewport sizes (if applicable)
- [ ] Checked with keyboard navigation (if applicable)
- [ ] Checked for visual regressions in related components

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.