ClickHouse / ClickHouse/adbc_clickhouse

Integrate with ADBC validation suite

Open
#5 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
25
Forks
8
Avg merge
2d 37m
Merged PRs (30d)
4

Description

ADBC provides a massive validation test suite that covers nearly everything: https://github.com/apache/arrow-adbc/blob/3078bb6ee00c7554de37f3b98fa47cde26004c0f/c/validation/adbc_validation_statement.cc

Not all of these will be applicable to ClickHouse, but it appears we can opt in/out of individual tests.

For example, see SnowFlake's implementation: https://github.com/apache/arrow-adbc/blob/3078bb6ee00c7554de37f3b98fa47cde26004c0f/c/driver/snowflake/snowflake_test.cc

The hardest/most annoying part is that we'd need to build the test in C++.

Alternatively, we could just port the tests that make sense to Rust, but it is also important to validate that the FFI functions correctly since that's how every other language will interact with the driver.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.