ClickHouse / ClickHouse/adbc_clickhouse

Implement `Statement::cancel()` (or make it a no-op)

Open
#20 2 comments 1 reaction 0 assignees View on GitHub
Dominant language
Rust
Stars
25
Forks
8
Avg merge
2d 37m
Merged PRs (30d)
4

Description

https://docs.rs/adbc_core/0.21.0/adbc_core/trait.Statement.html#tymethod.cancel

This is actually completely useless because executing a query requires `&mut self`, but possibly may be invoked via FFI: https://github.com/apache/arrow-adbc/issues/3454

This technically means it must be safe to call this concurrently to `Statement::execute()` despite both taking `&mut self`, which breaks Rust's soundness requirements for `&mut`. This is really problematic. But this is specifically a problem with the ADBC Rust API itself.

Blocked on the resolution of the linked issue. Until then, returning `NotImplemented` without touching `self` at all seems the safest.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.