ClickHouse / ClickHouse/ClickStack-helm-charts

Reference API key from a Kubernetes secret

Open
#138 1 comment 3 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
75
Forks
54
Avg merge
3d 19h
Merged PRs (30d)
7

Description

Hello!

While trying to reference a API key from a k8s secret, as mentioned in the [README](https://github.com/hyperdxio/helm-charts?tab=readme-ov-file#referencing-a-secret-in-valuesyaml), helm fails to render the template and apply it.

[secrets.yaml template](https://github.com/hyperdxio/helm-charts/blob/main/charts/hdx-oss-v2/templates/secrets.yaml) is set to always create a k8s secret from the apiKey value.

Should the secret be created only if the apiKey value is set, like so?
```yaml
{{- if not .Values.hyperdx.apiKey.valueFrom }}
apiVersion: v1
kind: Secret
metadata:
name: {{ include "hdx-oss.fullname" . }}-app-secrets
labels:
{{- include "hdx-oss.labels" . | nindent 4 }}
type: Opaque
data:
api-key: {{ .Values.hyperdx.apiKey | b64enc }}
{{- end }}
```

Thank you

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.