ClickHouse / ClickHouse/ClickHouse

multiple disks on the same volume are unbalanced

Open
#54,908 3 comments 0 reactions 0 assignees View on GitHub
comp-disk-abstractions external question
Dominant language
C++
Stars
49.9k
Forks
9k
Avg merge
21h 32m
Merged PRs (30d)
515

Description

In the multi-disk storage policy, when there are many disks under the same volume, the data storage is very unbalanced
![image](https://github.com/ClickHouse/ClickHouse/assets/20608540/88fd418c-a767-40be-9711-a7ce51dac0ff)

config.xml
```


default
disk1
disk2
disk3
disk4
disk5
disk6
disk7
disk8
disk9
disk10
disk11
disk12
disk13


```

source code analysis, whether can be changed to multi-disk detection of available space

```
ReservationPtr StoragePolicy::reserve(UInt64 bytes, size_t min_volume_index) const
{
for (size_t i = min_volume_index; i < volumes.size(); ++i)
{
const auto & volume = volumes[i];
for (const auto & disk : volume->getDisks())
{
auto reservation = volume->reserve(bytes);
if (reservation)
return reservation;
}
}
LOG_TRACE(log, "Could not reserve {} from volume index {}, total volumes {}", ReadableSize(bytes), min_volume_index, volumes.size());

return {};
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.