CliMA / CliMA/Land

Change to new clima parameter handling

Open
#53 3 comments 0 reactions 0 assignees View on GitHub
ClimaParameters :control_knobs:
Dominant language
Julia
Stars
107
Forks
23
PR merge metrics
No merged PRs in 30d

Description

If this repo is still being maintained, then we should apply the new clima parameter handling. An example of how to do this is in [this PR](https://github.com/CliMA/ClimaLSM.jl/pull/68).

A success metric for closing this issue involves:
- Having a centralized module for where clima parameters from dependency packages can be accessed (see, e.g., [CloudMicrophysics.jl's Parameters module](https://github.com/CliMA/CloudMicrophysics.jl/blob/e32b555cb8e958a5dc852883ec4718a9e5b63f92/src/Parameters.jl), which forwards methods for handling thermodynamic variables).
- Removing Land.jl's dependence on CLIMAParameters (i.e., `using CLIMAParameters` / `import CLIMAParameters` does not live in `Land/src/`).
- All parameters that were previously obtained from CLIMAParameters methods are obtained from the CLIMAParameters [toml file](https://github.com/CliMA/CLIMAParameters.jl/blob/488a615476370b88a68aa5273c40bc18dbcf4cb8/src/parameters.toml)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.