CliMA / CliMA/CloudMicrophysics.jl
High tolerance needed for perf model IN calibration tests
- Dominant language
- Julia
- Stars
- 55
- Forks
- 11
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 8
Description
Within the perfect model calibration tests in the `ice_nucleation_calibration.jl` file under `test`, each test is being run with different, arbitrary tolerances. Calibration might not be working as we want it because some values wouldn't pass the test if we set a reasonable relative tolerance.
For example:
ABDINM calibrated _c_ coefficient is tested with an arbitrary absolute tolerance of 3. This is because the true value is around ~2, but because of the noise and standard deviation given to the priors, the calibrated value could be as high as 4. This is double the true value and requires around rtol = 0.9 which seems wrong. However, if we run the `perfect_calib.jl` file, we see that the resulting parcel output for ICNC matches fairly well with parcel outputs using the true coefficients.
Need to check with Ollie to see if this is okay. If not, find a way for these unit tests to pass with a relative tolerance of ~0.3.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.