CliMA / CliMA/ClimaCore.jl

Old space restarts do not propagate many kwargs

Open
#2,214 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Julia
Stars
117
Forks
19
Avg merge
3d 4h
Merged PRs (30d)
41

Description

As seen in

```julia
if type == "SpectralElementSpace1D"
Spaces.SpectralElementSpace1D(topology, quadrature_style)
else
Spaces.SpectralElementSpace2D(topology, quadrature_style)
end
```
This excludes several keyword arguments. I think the reason we don't currently see this issue is that most restart files use grids, which results in us taking a different code path.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the restart code containing the SpectralElementSpace1D and SpectralElementSpace2D branch shown in the issue. Compare the keyword arguments accepted by the restart path with those passed to the space constructors, then reproduce an old space restart that uses non-grid options. Done means all relevant keyword arguments propagate correctly for both space types.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
hpc
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.