CliMA / CliMA/ClimaCore.jl

Fix post processing for VIJHF datalayouts

Open
#2,058 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Julia
Stars
117
Forks
19
Avg merge
3d 4h
Merged PRs (30d)
41

Description

The issue seems to be that `slab` for `VIJHF` returns `view(parent(data), :, :, h, :)`, which we try to index in `rmatmul1(M, in_slab, i, j)`, leading to scalar indexing. We may be able to simply wrap that call in an SArray, but I'd like to look at this more carefully.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by tracing the VIJHF datalayout path from slab into rmatmul1, focusing on the returned view and the reported scalar-indexing failure. Review how SArray is used in the surrounding post-processing code. Done means VIJHF post-processing no longer triggers scalar indexing, with the relevant behavior verified by the project's tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
hpc
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.