Distributed limiters aren't communicating correctly
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 118
- Forks
- 19
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 38
Description
Describe the bug
The QuasimonotoneLimiter constructor calls create_ghost_buffer:
https://github.com/CliMA/ClimaCore.jl/blob/9c220472af5dab549275c183975a5b1fe735d0ba/src/Limiters/quasimonotone.jl#L53-L54
However in the only test, this currently returns nothing
https://github.com/CliMA/ClimaCore.jl/pull/1510
Probably not worth fixing at the moment: in #1494, we will probably change the limiters so that they will be applied only within the element (i.e. no communication should be required).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read src/Limiters/quasimonotone.jl at lines 53-54 and the only limiter test referenced in pull request #1510. Check the planned limiter changes in issue #1494 before deciding whether communication still needs coverage. Done means resolving the behavior with a focused test, or confirming that #1494 makes this issue obsolete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- distributed-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100