CliMA / CliMA/ClimaCore.jl

Update limiters

Open
#1,494 7 comments 0 reactions 2 assignees Claimed by @dennisYatunin View on GitHub
enhancement SDI
Dominant language
Julia
Stars
117
Forks
19
Avg merge
3d 4h
Merged PRs (30d)
41

Description

Our limiters need to be updated in several aspects:

- GPU compatibility (#1493)
- Implement "water borrowing" (discussed in #1386)

For unit tests, I would like to also add some simple analysis. For each limiter, we should document the following cases:

- Low frequency sin wave in the interior domain
- High frequency sin wave (sawtooth) in the interior domain
- Low frequency sin wave on the boundary
- High frequency sin wave (sawtooth) on the boundary

Documenting these four cases across a frequency range really characterizes what the limiter is doing. Adding this to the docs would be helpful, and give us confidence about how the limiters are impacting our simulations.

We could go a step further and let advection or diffusion operate on the perturbation of the limited state (`perturbed_state = (state - limited_state)`), and that would help us get and idea of how we're impacting the phase space, but this is more subjective since different terms can absorb / balance this impact, so it's really more model-dependent.

cc @tapios

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.