Non-product upwind reconstuction operators
- Dominant language
- Julia
- Stars
- 117
- Forks
- 19
- Avg merge
- 3d 8h
- Merged PRs (30d)
- 38
Description
**Is your feature request related to a problem? Please describe.**
The current upwind operators compute the product of the vector and the reconstruction of the value. This is a problem in two ways:
- when computing the Jacobian of the implicit tendency: currently the code uses [a convoluted approach to back out the contribution](https://github.com/CliMA/ClimaAtmos.jl/blob/a3e4fd2450eb9f207eacdbdd78f66ab60fd08abf/src/tendencies/implicit/wfact.jl#L36-L39)
- splitting the contribution from the horizontal and vertical velocities: we want to use the combined velocity to determine the upwinding direction, but only multiply by one part
**Describe the solution you'd like**
Define an `UpwindBiasedC2F`/`Upwind3rdOrderC2F` which just do the reconstruction part.
**Describe alternatives you've considered**
none
**Additional context**
none
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.