CliMA / CliMA/ClimaAtmos.jl

Tendency flags should modify Jacobians

Open
#3,000 0 comments 0 reactions 0 assignees View on GitHub
EDMF :tornado: Numerics
Dominant language
Julia
Stars
127
Forks
38
Avg merge
1d 21h
Merged PRs (30d)
25

Description

When turning off an implicit tendency, the corresponding Jacobians need to be set to zero. Currently the tendency flags (e.g. `zero_tendency`, `advection_test`, `prognostic_tke`) don't modify the Jacobians.

Contributor guide

No contributing guide indexed for this repository

Research direction

No files or tests are named. Start by locating the implementations of the zero_tendency, advection_test, and prognostic_tke flags and the Jacobian assembly; verify which implicit tendencies each flag disables. Done means the corresponding Jacobian entries are zero when those flags are turned off, with tests covering the affected flags.

Written by the indexing model from the issue text.

Assessment

Tech stack
julia
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.