CleverRaven / CleverRaven/Cataclysm-DDA

For effects with `dur_add_perc` when `dur_add_perc` is less than 100, when applied by enchantment, `remove_message` prints every turn

Open
#87,366 1 comment 0 reactions 0 assignees View on GitHub
(S2 - Confirmed)
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
1d 21h
Merged PRs (30d)
185

Description

### Describe the bug

As title. Found when working on #87365

### Attach save file

[MoM-trimmed.tar.gz](https://github.com/user-attachments/files/28471936/MoM-trimmed.tar.gz)

### Steps to reproduce

1) Load changes from #87365
2) Load game and take a step
3) Check message log

### Expected behavior

You only get the removal message when the effect disappears permanently (or until the next time)

### Screenshots

Image

### Versions and configuration

- OS: Windows
- OS Version: 10.0.26100.8457 (24H2)
- Game Version: cdda-experimental-2026-05-27-1638-dirty [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Portal Storms Ignore NPCs [personal_portal_storms],
Mind Over Matter [mindovermatter]
]

### Additional context

No vanilla effect has both a `remove_message` and an `dur_add_perc` below 100, hence why this wasn't noticed before.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.