CleverRaven / CleverRaven/Cataclysm-DDA

Error "Bad tag" when trading with Russel Connelly in the New England Community Church

Open
#83,140 4 comments 0 reactions 0 assignees View on GitHub
(S2 - Confirmed)
Dominant language
C++
Stars
13.2k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

### Describe the bug

When you start a new trade with Russel Connely in the NECC you are presented with an error screen and his name is displayed as "????" In the trading interface.

### Attach save file

Can't access the save file from my phone.

### Steps to reproduce

1. Generate the NECC in a new world.
2. Visit the second floor of the main building.
3. Talk to the hunter that sells pelts and asks for monster throphies, Russel.
4. Try to trade with him.
5. See the error and the "????" In his name in the trade window.

### Expected behavior

To be able to trade without errors.

### Screenshots

_No response_

### Versions and configuration

- OS: Android
- OS Version: Manufacturer: samsung; Model: SM-A525M; Release: 14; Incremental: A525MUBSCFYF1;
- Game Version: cdda-experimental-2025-09-30-0013 243c298 [64-bit]
- Graphics Version: Tiles
- Game Language: English [en]
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Bionic Professions [package_bionic_professions],
Tamable Wildlife [Tamable_Wildlife],
Mythical Martial Arts [MMA],
Translate Complex Dialogue [translate_dialogue],
Bombastic Perks [bombastic_perks],
Portal Storms Ignore NPCs [personal_portal_storms],
Slowdown Fungal Growth [no_fungal_growth]
]

### Additional context

DEBUG : Bad tag. '' (0 - 8)

REPORTING FUNCTION : void parse_tags(std::string &, const const_talker &, const const_talker &, const const_dialogue &, const itype_id &)
C++ SOURCE FILE : /home/runner/work/Cataclysm-DDA/Cataclysm-DDA/android/app/jni/src/../../../../src/npctalk.cpp
LINE : 2608
VERSION : cdda-experimental-2025-09-30-0013 243c298

Contributor guide

Open the contributing guide

Research direction

Start in src/npctalk.cpp at parse_tags, line 2608, and reproduce the trade with Russel Connelly in the New England Community Church using the listed game version and mods. Trace the bad tag and inspect the dialogue or trade data it processes. Done means the trade window opens without the error and displays Russel's name correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.