CleverRaven / CleverRaven/Cataclysm-DDA

New generators if filled with fuel or other liquid, when deployed spills fuel onto floor.

Open
#79,015 6 comments 0 reactions 0 assignees View on GitHub
(S2 - Confirmed)
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

### Describe the bug

Shouldn't spill fuel or liquid onto floor when being deployed.

Either an oversight or unintended of https://github.com/CleverRaven/Cataclysm-DDA/pull/78910 @GuardianDll

### Attach save file

[Zakhadia_BigCity-trimmed.tar.gz](https://github.com/user-attachments/files/18340593/Zakhadia_BigCity-trimmed.tar.gz)

### Steps to reproduce

Find a generator i found mine at a police blockade, make sure it has fuel, activate it to deploy, and watch all the fuel spill onto the floor.

### Expected behavior

Basically it should contain the fuel, or indicate that it needs to be emptied first before being deployed.

### Screenshots

![image](https://github.com/user-attachments/assets/6efc88f3-953b-46e2-8bf0-52c0e34f68fe)
![image](https://github.com/user-attachments/assets/75441daa-9849-41a2-8ca3-5482a38db917)
![image](https://github.com/user-attachments/assets/547a062a-63fd-48a7-9a14-ff742947ae2c)

### Versions and configuration

- OS: Windows
- OS Version: 7
- Game Version: 3be8cc8 [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Stats Through Skills [StatsThroughSkills],
SpeedyDex [speedydex],
Disable NPC Needs [no_npc_food],
Medieval Mod Reborn [Medieval_Mod_Reborn],
Tamable Wildlife [Tamable_Wildlife],
Mind Over Matter [mindovermatter],
Bombastic Perks [bombastic_perks],
Slowdown Fungal Growth [no_fungal_growth]
]

### Additional context

The screenshot b4 was to show it having fuel i just grabbed one from the conversation i was having in discord about the repair cost.

https://discord.com/channels/598523535169945603/598523535169945607/1326364560763912262

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the deployment behavior with the attached save file, then read PR 78910 and trace the generator deployment path it changed. Compare a fueled generator with the expected deployment behavior. Done means deployment preserves the liquid or clearly prevents deployment until the generator is emptied.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.