CleverRaven / CleverRaven/Cataclysm-DDA

SDL Bump or ImGUI Broke Android Shortcuts w/Software Rendering and Joystick is Anchored

Open
#78,087 4 comments 0 reactions 0 assignees View on GitHub
(S2 - Confirmed) ImGui OS: Android
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
200

Description

### Describe the bug

Android Shortcuts do not display when navigating Main Menu on boot.
Virtual Joystick is anchored to top left corner (input is less accurate to left/top directions).
Once Android Shortcuts are displayed, they are not selectable (selects whatever is highlighted on game window)

### Attach save file

N/A

### Steps to reproduce

1. Install cdda-experimental-2024-04-05-2105 or later (still present in 11-03-2024)
2. Observe missing Android Shortcut bar on main menu when opened
3. Display the Android Shortcut bar (i.e. Options menu > Default Character Name > Cancel Text Input)
4. Attempt to select a shortcut option (i.e. Tab to go to next Options page)
5. Enter key is input instead of selected shortcut (Default Char Name input reopens)

### Expected behavior

I would expect no regression in shortcut behavior after #72154 and #72345 integration

### Screenshots

3eb062c Version Not Working Screenshot:
![3eb062c_Not_Working](https://github.com/user-attachments/assets/5f36df79-ddda-4537-9a8a-bf3db9f7f43b)

dd1adff Version Working Screenshot:
![dd1adff_Working](https://github.com/user-attachments/assets/09e96fbf-0ab4-4566-975a-2a44afeac674)

### Versions and configuration

OS: Android 14 64bit
Game Version (Not Working): 3eb062c (cdda-android-x64-2024-04-05-2105)
Game Version (Working): dd1adff (cdda-android-x64-2024-02-26-0341)

### Additional context

Software Rendering - Enabled
Force Fullscreen - Enabled/Disabled No Impact
Trap Back Button - Enabled
Native Android Menus - Disabled

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue on Android 14 with software rendering using the listed working and broken game versions. Compare changes from #72154 and #72345 involving SDL, ImGUI, Android shortcuts, and input; done means shortcuts appear on the main menu, can be selected, and the virtual joystick is correctly anchored.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, cpp
Domain
game-dev, mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.