CleverRaven / CleverRaven/Cataclysm-DDA

Message order is not always correct

Open
#7,533 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

(P5 - Long-term) (S2 - Confirmed) <Bug> Help Wanted Info / User Interface
Dominant language
C++
Stars
13.2k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

Sometimes, the order the messages come in is wrong.

Real example after drinking 1 mutagen:
“You gain a mutation called Herbivore!
You gain a mutation called Leg Tentacles!
You gain a mutation called Poison Resistant!
Oops. You've must blacked out for a minute or so.
You drink your mutagen.
You wake up.”
This is from the broad sidebar, so this means: normally, new messages appear at the bottom. But this log looks a bit messed up. According to the log, you get the mutations before you drinke the mutagen, and you drink it while you are passed out … lol

It seems to me the message order gets wrong always if multiple messages go into the log at the same time, I am not sure exatly.

Oh, and I know C:DDA has this bug for a very long time already. Still in master.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported scenario of drinking one mutagen and inspect the broad sidebar message log. Trace how simultaneous messages are added and determine why their displayed order differs from the gameplay order. Done means the mutation, blackout, drinking, and waking messages consistently appear in the correct sequence.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.