CleverRaven / CleverRaven/Cataclysm-DDA

Non-poisonous and poisonous items get stacked together in the eat menu

Open
#73,687 2 comments 1 reaction 0 assignees View on GitHub
(S2 - Confirmed) [C++] Info / User Interface Items: Food / Vitamins Quality of Life
Dominant language
C++
Stars
13.2k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

### Describe the bug

![image](https://github.com/CleverRaven/Cataclysm-DDA/assets/59517351/7c13363c-259a-481d-ba83-360328ca2c28)
vs
![image](https://github.com/CleverRaven/Cataclysm-DDA/assets/59517351/bb416c0e-fae1-43eb-81b9-5a5852b70107)

### Attach save file

n/a

### Steps to reproduce

1. Forage and find either wild roots or shrooms which have both `FORAGE_POISON`.
2. Make sure some of them are poisonous.
3. Try to eat them.
4. They get batched together.

### Expected behavior

They would be separate like in the inventory screen (second screenshot).

### Screenshots

_No response_

### Versions and configuration

- OS: Linux
- OS Version: LSB Version: n/a; Distributor ID: Arch; Description: Arch Linux; Release: rolling; Codename: n/a;
- Game Version: cdda-experimental-2024-05-11-0903 d78e605 [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Portal Storms Ignore NPCs [personal_portal_storms],
Slowdown Fungal Growth [no_fungal_growth],
Innawood [innawood]
]

### Additional context

Maybe related to #24981

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue with forage items that have FORAGE_POISON, then compare grouping in the eat menu with the inventory screen. Trace how poisonous and non-poisonous items are batched, and verify that they appear as separate groups in the eat menu.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.