CleverRaven / CleverRaven/Cataclysm-DDA

Armor damaged when weapon blocks all damage

Open
#73,152 1 comment 0 reactions 0 assignees View on GitHub
(S2 - Confirmed)
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
200

Description

### Describe the bug

Armor can be damaged even when an incoming attack is blocked by the wielded weapon

### Attach save file

n/a

### Steps to reproduce

1. Be wearing basic clothing
2. Be wielding a weapon that can block damage
3. Take melee hits
4. Observe eventually that a hit where all the damage is blocked by the wielded weapon still damages the armor

### Expected behavior

The log message indicates that all the damage was blocked by the weapon. Presumably without any of the damage being blocked by the armor. The armor shouldn't be able to be damaged if there was no damage getting past the blocking weapon.

### Screenshots

![image](https://github.com/CleverRaven/Cataclysm-DDA/assets/6325435/4a0584d6-2aa9-4d96-8a8c-42e8289b1001)

### Versions and configuration

- OS: Windows
- OS Version: 10.0.19045.4170 (22H2)
- Game Version: cdda-experimental-2024-04-15-0327 ef202a4 [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Portal Storms Ignore NPCs [personal_portal_storms],
Slowdown Fungal Growth [no_fungal_growth]
]

### Additional context

It might be that the armor is contributing some blockage and the log message is inaccurate.

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue using basic clothing, a weapon that can block damage, and repeated melee hits with the listed mods and experimental build context. Check the combat damage result and log for a fully blocked hit; done when armor is not damaged when the weapon blocks all damage, or the log accurately reflects any armor contribution.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.