CleverRaven / CleverRaven/Cataclysm-DDA

Invalid comestibles still selectable; time passes even when nothing is consumed.

Open
#70,684 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

(S2 - Confirmed) <Bug> Items: Food / Vitamins
Dominant language
C++
Stars
13.2k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

Describe the bug

Originally posted by a user in the community discord. Confirmed present by myself.

Invalid-marked comestibles ( e.g. Bleach, Ammonia Solution, etc ) can still be selected from the (E) consume menu. The marked 8 seconds consume time passes, and the item is (correctly!) not consumed. However, this apparently remains a little confusing for new players.

Attach save file

N/A

Steps to reproduce

Make a world, spawn in a gallon jug of bleach. Attempt to consume it via the main Consume menu. Watch time pass, and no message on the menu.

Expected behavior

An invalidating message on the consume menu e.g. Carnivores trying to eat Plant foods, a message in the chat log saying "you can't eat that", or outright moving them to Chemicals rather than Comestibles, may be preferable.

Screenshots

No response

Versions and configuration
  • OS: Windows
    • OS Version: 10.0.19045.3803 (22H2)
  • Game Version: fb058db [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda]
    ]
Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by reproducing the issue with a spawned gallon of bleach and trace the main Consume menu's handling of invalid-marked comestibles. Done should mean invalid items no longer let the eight-second action proceed silently, with the chosen user-facing behavior covered by an appropriate test.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.