CleverRaven / CleverRaven/Cataclysm-DDA

<npc_name> is the ideal companion

Open
#69,769 1 comment 0 reactions 0 assignees View on GitHub
(S2 - Confirmed) [C++] Info / User Interface
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
200

Description

### Describe the bug

Similar text to that in title appears when examining npc traits. String printing is not working here, or this was left as a placeholder.

### Attach save file

N/A trivial

### Steps to reproduce

Talk to npc and select option "I'd like to know a bit more about your abilities"
Move focus via mouse or keyboard to their traits and observe trait description.

### Expected behavior

Consider the "brave" trait shown in screenshot. Same issue exists for other traits that use .

Expected text:
Brave: Pete Bartholomew knows the name of fear...

Observed text:
Brave: knows the name of fear...

### Screenshots

![image](https://github.com/CleverRaven/Cataclysm-DDA/assets/19167795/3257d72d-c65b-4a20-86c6-380fde44bbc4)

### Versions and configuration

- OS: Linux
- OS Version:
- Game Version: 6f1b1db [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Portal Storms Ignore NPCs [personal_portal_storms],
Slowdown Fungal Growth [no_fungal_growth],
Mind Over Matter [mindovermatter],
Bombastic Perks [bombastic_perks]
]

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue by talking to an NPC, selecting “I'd like to know a bit more about your abilities,” and examining the traits, then search the trait-description and NPC dialogue code for the literal placeholder. Done means the displayed trait text uses the NPC's name, such as “Pete Bartholomew,” for Brave and the other affected traits.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.