CleverRaven / CleverRaven/Cataclysm-DDA

Items like "storage battery case" or "cargo carrier" show "repair with..." but can't be repaired because they are a vehicle part

Open
#69,618 5 comments 0 reactions 0 assignees View on GitHub
(S2 - Confirmed)
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

### Describe the bug

The storage battery case in particular has "repair using..." but can't repair using these tools.
[GuardianDll](https://github.com/GuardianDll):
> It is vehiclepart, and affected by degradation, you can't fix it higher than it's current state

Since it can not be repaired, it shouldn't say it can be repaired with, and should state something like "This item can't be repaired"

### Attach save file

N/A trivially reproducible

### Steps to reproduce

1. Obtain damage storage battery case (run it over with a car or something)
2. Try to repair it using the tools it lists with the ability to repair it.
3. Can't repair it

### Expected behavior

The item shouldn't say it can be repaired with... if it can't be repaired due to degredation

### Screenshots

Shows my storage battery case is damaged:
![Untitled](https://github.com/CleverRaven/Cataclysm-DDA/assets/24307650/fdda5ee7-8ff2-436c-8624-c0908b80dfbe)
Shows the storage battery case says that it can be repaired with arc welder and other tools:
![Untitled](https://github.com/CleverRaven/Cataclysm-DDA/assets/24307650/b5b0c4e5-fe5e-41ca-95e4-55cf56a0ea6a)
Message I get when trying to repair with the arc welder:
![Untitled](https://github.com/CleverRaven/Cataclysm-DDA/assets/24307650/0c39ac06-6f89-4139-b63c-d85935a8a477)

### Versions and configuration

- OS: Windows
- OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
- Game Version: eca466b [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Slowdown Fungal Growth [no_fungal_growth],
No Fungus [No_Fungus],
Stats Through Skills [StatsThroughSkills]
]

### Additional context

Edited and changed bug report slighty from [GuardianDll](https://github.com/GuardianDll) telling me that it is intended for the vehicle parts to not be repaired

Contributor guide

Open the contributing guide

Research direction

No source file, test, or entry point is named. Reproduce the storage battery case scenario with the listed repair tools, then locate the code that generates repair options and the failure message for degraded vehicle parts; done means the item no longer advertises unavailable repairs and the behavior is covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.