CleverRaven / CleverRaven/Cataclysm-DDA

Can start disassembly of item with 1 broken arm despite not being able to hold it with both arms or completing in-progress disassembly

Open
#69,489 2 comments 0 reactions 0 assignees View on GitHub
(S2 - Confirmed) stale
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
200

Description

### Describe the bug

If you have 1 broken arm and attempt to disassemble something like a recharging station, you are able to do so without issue. If you stop the disassembly for whatever reason, it will yield an in-progress item for you to continue disassembly. Since you have one broken arm, you can not pick up the craft to be able to disassemble it.

### Attach save file

N/A This is trivially reproducible

### Steps to reproduce

1. Break 1 arm of character
2. Start disassembly of recharging station
3. Stop the disassembly and try to continue the craft
4. Unable to continue craft because you cant pick it up

### Expected behavior

There are a few ways to handle this:
1. Allow the craft to be completed with 1 arm, but much slower.
2. Since you cant pick up the craft, disallow the character from being able to disassemble it in the first place.
3. Disallow the disassembly all together.

I like option 1, to allow the disassembly, but maybe 2.25x slower since one arm is un-usable and you are presumably not proficient with only using 1 arm. Ofcourse, if both arms are broken, then disallow disassembly

### Screenshots

_No response_

### Versions and configuration

- OS: Windows
- OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
- Game Version: 4f24d43 [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Slowdown Fungal Growth [no_fungal_growth],
Stats Through Skills [StatsThroughSkills]
]

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

No source file, test, or entry point is identified. Reproduce the issue using the listed four steps, then trace disassembly and item-handling logic to decide how a character with one broken arm should proceed; done means the chosen behavior is consistent for starting, stopping, and completing disassembly, with both-arm injury still handled.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.