CleverRaven / CleverRaven/Cataclysm-DDA

CORNERED_FIGHTER works weirdly with monster aggression

Open
#67,653 8 comments 1 reaction 0 assignees View on GitHub
[C++] Help Wanted Monsters
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

### Describe the bug

The critters affected by it do not seem to fight back.

### Attach save file

n/a

### Steps to reproduce

1. Spawn a bear in an enclosed space where it can not run.
2. Corner it.
3. Nothing happens.
4. Hit it.
5. Nothing happens again.

I might be severely dumb but if I saw that correctly the bear does not even aggro under normal circumstances if you hit it.
I also tested with `mon_cat` and added `CORNERED_FIGHTER` into its JSON, still no dice.

### Expected behavior

The creature gets aggressive.

I wonder if this is another case of a feature silently breaking, like the MEAT `placate_trigger`.

### Screenshots

_No response_

### Versions and configuration

- OS: Linux
- OS Version: LSB Version: n/a; Distributor ID: Arch; Description: Arch Linux; Release: rolling; Codename: n/a;
- Game Version: 5cca213 [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Slowdown Fungal Growth [no_fungal_growth],
Bionic Professions [package_bionic_professions]
]

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by locating the creature JSON definition for CORNERED_FIGHTER and the aggression handling for bears and mon_cat. Reproduce the enclosed-space and attack steps from the issue, then trace why the flag does not trigger aggression. Done means affected creatures fight back when cornered or hit, with a regression test if the existing test structure supports it.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.