CleverRaven / CleverRaven/Cataclysm-DDA
Forges are *substitutes* for each other, down to the individual charge
- Dominant language
- C++
- Stars
- 13.1k
- Forks
- 4.6k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 200
Description
### Describe the bug

60kJ = ~62.4g of charcoal??? This is a value of about 1MJ/kg.
Wood contains about 16-18MJ/kg. Charcoal and coal contain more (it varies but it's not off by an entire 10x!!).
For an even worse comparison, we can do propane. Propane has an energy density of about 25MJ/L, and one unit of propane is 1mL. So that's 60mL, or in other words: **60kJ electricity = ~1.5MJ of propane.**
This is why:
https://github.com/CleverRaven/Cataclysm-DDA/blob/9020c00c9be57e2d0b21f023bf95482de327e481/data/json/items/tool/metalworking.json#L70
All the forges are *substitutes*. They should not be substitutes.
### Attach save file
N/A
### Steps to reproduce
Open the crafting menu
### Expected behavior
"sub" should be removed from all forges that aren't actual duplicates (i.e. mounted and non-mounted electric forge).
A new requirements set should be made, containing all the previous forges.
The requirements set should have the forges in some proportion which makes energy sense (**not** 1 unit of charcoal forge = 1 unit of electric forge)
### Screenshots
_No response_
### Versions and configuration
9020c00c9be57e2d0b21f023bf95482de327e481
### Additional context
_No response_
Contributor guide
Research direction
Start with data/json/items/tool/metalworking.json at the linked forge requirements and inspect how the crafting menu interprets the "sub" entries. Define a separate requirements set containing the forges, using energy-consistent proportions rather than one-for-one substitution. Reproduce through the crafting menu and verify mounted and non-mounted electric forges remain valid duplicates while other forge types are not substitutes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100