CleverRaven / CleverRaven/Cataclysm-DDA
Throwing accuracy in the sidebar does not seem to account for throwing skill.
- Dominant language
- C++
- Stars
- 13.2k
- Forks
- 4.6k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 205
Description
### Describe the bug
When throwing at enemies with some level of throwing skill, the sidebar lists hit chances in the low single-digits despite actual testing hitting almost 90% of the time. This does not seem to apply at 0 throwing, where you do miss about as often as the sidebar indicates. The problem exacerbates at higher levels. It seems the sidebar accuracy might not be taking throwing skill into account.
### Attach save file
N/A
### Steps to reproduce
1. Spawn a debug monster some distance away (5-10 tiles works).
2. Spawn a bunch of rocks. Wield them and set their hotkey to 't' to speed up testing.
3. Set display style to "numbers" instead of "bars" in the options menu for a more accurate readout.
4. With throwing skill at 0, aim a throw. Note the hit chance is only around 3-4%, with 95% miss chance.
5. Throw a bunch of rocks, note that almost all miss.
6. Set throwing skill higher, e.g. around 4.
7. Aim a throw: note the hit chance has barely changed.
8. Throw a bunch of rocks: note that you're now hitting the majority of your rocks.
9. Set throwing to 10.
10. Aim: Note hit chance is still showing the same values as throwing skill 0.
11. Throw a bunch of rocks, note that you're now almost always getting regular or good hits.
### Expected behavior
I expect the hit chance readout to give an accurate representation of my chance to hit.
### Screenshots
My listed chance to hit (at 10 throwing)

The result of 10 thrown rocks.

### Versions and configuration
- OS: Windows
- OS Version: 10.0.22621.1265 (22H2)
- Game Version: 80175a7 [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Portal Storms Ignore NPCs [personal_portal_storms],
No Fungal Growth [no_fungal_growth],
Bionic Professions [package_bionic_professions]
]
### Additional context
_No response_
Contributor guide
Research direction
Reproduce the sidebar readout and actual rock throws with throwing skill set to 0, 4, and 10, following the issue's debug-monster steps. Trace the calculation used for the displayed hit chance and compare it with the throwing result; done means the sidebar changes appropriately with throwing skill and matches observed accuracy, with regression coverage for the discrepancy.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100