CleverRaven / CleverRaven/Cataclysm-DDA

Hub 01 modular defense system doesn't appear to apply armor correctly

Open
#64,048 4 comments 0 reactions 0 assignees View on GitHub
(S2 - Confirmed)
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

### Describe the bug

I decided to try out the modular defense system from Hub 01 missions. So far I have the "Hub 01 modular defense system" (robofac_armor_rig) and the "Hub 01 kinetic skirt" (robofac_rubber_skirt). I've inserted the kinetic skirt into the defense system (which wasn't exactly intuitive, but I got there eventually) but now I'm confused whether the armor is actually being applied or not.

Here's my load out with the skirt inserted:

![image](https://user-images.githubusercontent.com/504167/223582268-dbcfd987-89f4-48fe-96ef-278c7c396a4a.png)

Or, if I instead look at the body status window for the hip (which should be covered by the skirt):

![image](https://user-images.githubusercontent.com/504167/223582370-ad2b3f6e-8721-4e3e-96f8-170986be627f.png)

The skirt _should_ be applying much more protection to the hips & thighs:

![image](https://user-images.githubusercontent.com/504167/223582449-b43fe44d-a1b2-46eb-a235-efad5f4b6805.png)

But doesn't seem to be -- at least according to the two places I'd normally check armor values show above.

Interestingly, the pocket for the skirt seems to understand the intended armor values:

![image](https://user-images.githubusercontent.com/504167/223582559-cbf83ff9-d9e9-4dd5-9056-59520d579751.png)

... but I still don't see them being applied.

Unless I'm doing something completely wrong (certainly possible, but if so _something_ seems like it should be made more clear!)

### Attach save file

[TESTING-trimmed.tar.gz](https://github.com/CleverRaven/Cataclysm-DDA/files/10915080/TESTING-trimmed.tar.gz)

### Steps to reproduce

1. Create a new character.
2. Spawn in "Hub 01 modular defense system (poor fit)" and "Hub 01 kinetic skirt"
3. Wear the modular defense system.
3b. Observe the base armor values for the modular defense system are applied to hips & thighs.
4. Insert the kinetic skirt into the modular defense system. (This seems to always go in the correct pocket by default, but it's worth confirming)
4b. Observe that the armor values applied to hips and thighs are unchanged.

Notes:
- Inserting the skirt before wearing the defense system does not seem to change anything.
- The same behavior is observed with the "Hub 01 kinetic mantle" and the "Hub 01 soldier skirt", so neither the position nor the type of component seem to matter.

### Expected behavior

I should see the armor values from the inserted component applied in both the body status and sort armor windows.

### Screenshots

(See description)

### Versions and configuration

- OS: Windows
- OS Version: 10.0.22621.1265 (22H2)
- Game Version: 9f7a0c8 [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Portal Storms Ignore NPCs [personal_portal_storms],
No Fungal Growth [no_fungal_growth],
Bionic Professions [package_bionic_professions]
]

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by loading the attached save or following the reproduction steps with the modular defense system and kinetic skirt. Compare the base armor values with the inserted component in the body status and sort armor windows, including the mantle and soldier skirt cases. Done means inserted component armor is reflected in both windows.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.