CleverRaven / CleverRaven/Cataclysm-DDA

Basket fish trap doesn't seem to work outside the reality bubble

Open
#62,151 10 comments 2 reactions 0 assignees View on GitHub
(S2 - Confirmed) <Bug> Fields / Furniture / Terrain / Traps
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
200

Description

### Describe the bug

I made a basket fish trap, made bait for it, and placed it in various places about a dozen time without catching anything at all, while still losing bait. Only one place stated that I wouldn't have much luck, while another, tried several times, had 3 visible fish in a rather small shallow pond of a size 5*4 tiles or so.
In all of these attempts I moved to the body of water, set the trap, and then returned to do whatever I needed to do elsewhere, checking back after a number of hours (at most the next day).

The only time I actually did catch anything was when I placed the trap two (in-game) tiles away from the PC extracting clay on a river bank.

### Steps to reproduce

1. Craft a basket fish trap
2. Craft fish bait
3. Load the trap fully with bait
4. Travel to a body of water and set the trap.
5. See the trap is marked as "active".
6. Move away to do something useful.
7. Return after the 3 hours is up and find the trap no longer active, bait missing, but nothing caught.
8. Repeat until you think it's not working.

### Expected behavior

The trap should work regardless of whether it's in the reality bubble or not when it times out. That's sort of the point of a passive trap.

### Screenshots

_No response_

### Versions and configuration

- OS: Windows
- OS Version: 10.0.19045.2130 (22H2)
- Game Version: 64e17c6 [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
No Fungal Growth [no_fungal_growth],
Bionic Professions [package_bionic_professions],
Innawood [innawood]
]
+ "Mod" to disable portal storms
+ Addition of bare bones basecamp companion recipes.

### Additional context

My PC's Survival skill is 8, which I think should be sufficient.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the basket fish trap sequence in a small body of water, comparing results near and outside the reality bubble. Read the basket trap, fish bait, and reality-bubble handling involved in the three-hour timeout. Done means a fully baited trap can resolve its catch after the player moves away, without losing bait when a catch should occur.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.