CleverRaven / CleverRaven/Cataclysm-DDA

Leftovers from the MBR vest era still haunt the game.

Open
#62,046 4 comments 0 reactions 0 assignees View on GitHub
(S2 - Confirmed) Items: Armor / Clothing
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
200

Description

### Describe the bug

Anyone remember MBR vests? those odd ballistic vests we had back when ballistic damage was registered as cut damage? The game apparently still does even though they were removed in #36920 (TWO YEARS ago) because we still have the armor plates that were meant to go inside that vest ingame, **specifically the steel plate, the hard steel plate, and the ceramic armor plate.**

The descriptions of these items still says they can be slid into a bullet resistant vest - despite not only being unable to fit into any of them. These things predate the ESAPI ballistic vests we have right now as well as predating nested containers, so they were fit into a vest with the *crafting menu* back then.

This wouldn't be much of an issue if they did not spawn ingame, but they do, and the steel plate even kept it's crafting recipe. New players who find these will be confused when they don't fit in their vests in their vests like the description says.

### Steps to reproduce

1. Spawn the three plates
2. Spawn an ESAPI vest
3. Attempt to insert the plates into your ESAPI vest, which you cannot do.

### Expected behavior

These things should probably have their descriptions changed, be obsoleted, or even repurposed to actually work. I would prefer them be obsoleted but the plates will need the correct flags and protection values if someone intends to make them useful.

### Screenshots

![image](https://user-images.githubusercontent.com/56202842/199301075-c301a1da-e8ac-4927-afb2-3de3d936c7a9.png)
ceramic armor plate. notice the description, which is a lie.
![image](https://user-images.githubusercontent.com/56202842/199301313-c8a7d538-b083-481a-bd02-555eaa189650.png)
example of the plate showing up ingame, dropped by a robot.
![image](https://user-images.githubusercontent.com/56202842/199301441-4957e710-5d32-4d88-af32-f8107ebc8097.png)
steel plate's recipe still existing, visible on the HHG.

### Versions and configuration

- OS: Windows 10 Version 1909
- Game Version: 300ec6d Experimental build 2022-11-01-0509
- Graphics Version: Tiles
- Ingame Language: English
- Mods loaded: [
Dark Days Ahead [dda],
No fungal growth [no_fungal_growth,
No rail stations [no_rail_stations].
]

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue with the steel plate, hard steel plate, ceramic armor plate, and an ESAPI vest, then inspect how those items spawn and how the steel plate's crafting recipe is exposed. Done means the three plates no longer misdescribe their compatibility or otherwise have a confirmed, working purpose, with their spawn and recipe behavior consistent with that decision.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.