CleverRaven / CleverRaven/Cataclysm-DDA
Shears and Forged Shears are identical
- Dominant language
- C++
- Stars
- 13.2k
- Forks
- 4.6k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 205
Description
### Describe the bug
Forged shears have the exact same stats as shears including plastic. Bronze shears at least weight 80 grams more and are fragile in melee.
Home made shears should be worse, or at least heavier, given that they uncraft into 5 scrap metal vs 3 scrap metal and 1 plastic chunk.
Both recipes are auto-learned.
### Steps to reproduce
Look at \data\json\items\tool\pets.json line 35+, and \data\json\recipes\tools\tool.json line 345+
### Expected behavior
Shears made with plastic should be lighter, and maybe also fragile_melee?
### Screenshots
_No response_
### Versions and configuration
Win 10, tiles, 593e21a
### Additional context
I've have patched this myself, but don't have time atm.
Contributor guide
Research direction
Start with data/json/items/tool/pets.json around line 35 and data/json/recipes/tools/tool.json around line 345. Compare the shears and forged shears stats, materials, and recipes, then make the intended distinction between them explicit and verify that the two entries no longer produce identical stats.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- json
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100