CleverRaven / CleverRaven/Cataclysm-DDA
can't refill my 2.5L canteen
- Dominant language
- C++
- Stars
- 13.2k
- Forks
- 4.6k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 205
Description
### Describe the bug
when I try to refill my 2.5L canteen from a 200L barrel of clean water, it throws up the following error and doesn't put water into the canteen
DEBUG : tried to put an item (water_clean, amount 1) in a container (2lcanteen) that cannot contain it
FUNCTION : fill_with
FILE : D:\a\Cataclysm-DDA\Cataclysm-DDA\src\item.cpp
LINE : 12067
VERSION : 60f648c
### Steps to reproduce
1. have a 200L barrel of clean water and an empty 2.5L canteen
2. Set the canteen's pocket to not automatically be used to carry stuff
3. Try to reload the canteen with the water from the barrel
4. Get the error
### Expected behavior
For the canteen to have water in it
### Screenshots
_No response_
### Versions and configuration
- OS: Windows
- OS Version: 10.0.18363.1556 (1909)
- Game Version: 60f648c [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
No Fungal Growth [no_fungal_growth],
Bionic Professions [package_bionic_professions],
Blaze Industries [blazeindustries],
No Rail Stations [No_Rail_Stations],
Stats Through Kills [stats_through_kills]
]
### Additional context
_No response_
Contributor guide
Research direction
Start in src/item.cpp around the reported fill_with function at line 12067, then reproduce the steps with a 2.5L canteen whose pocket is disabled for automatic carrying. Trace why water_clean is rejected when refilling from the 200L barrel; done means the canteen accepts clean water in this configuration without the error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100