CleverRaven / CleverRaven/Cataclysm-DDA

Improperly logged item movement when placing spillable containers into storage.

Open
#60,176 1 comment 0 reactions 0 assignees View on GitHub
(S2 - Confirmed)
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

### Describe the bug

Say you've got the Cauldron of Purification (CoP), from magiclysm, and you want to test to see if it can remove toxins from food without json diving or spoiler reading. So you put food that has toxins in it. Now you want to wait, but that requires putting it somewhere.

If you drop it on the ground, it can keep holding said items. However, if you put it into storage, any items inside it, such as powdered eggs, go directly into your inventory. There is no popup or warning about spillage, or items moving into your inventory.

![image](https://user-images.githubusercontent.com/22281606/184666610-28a682b4-a9c4-4e75-ae24-10b5bb31032b.png)
![image](https://user-images.githubusercontent.com/22281606/184666656-2d845875-0195-4628-a49c-b3e85c265075.png)
![image](https://user-images.githubusercontent.com/22281606/184666694-79fda957-d171-4949-8839-5948e5e41693.png)
![image](https://user-images.githubusercontent.com/22281606/184666725-9f02cfc3-2a29-49c6-bd01-33b8db68b314.png)

Favorite status of the cauldron or eggs has no change on result. AIM, drop, or multidrop all produce the same message, that you've dropped the `CoP > Powdered Eggs` which then somehow teleports the eggs back into your inventory.

### Steps to reproduce

Get a CoP (or possibly other spillable container)
Put some small solids into it, such as paper, or powdered eggs
Drop it into some cargo.
See the log say you've put the container, and it's contents into said cargo.
See the contents in your inventory.

### Expected behavior

A warning about spillage and the log stating properly that you've only put the CoP and not the eggs into cargo
or
The ability to place spillable containers into cargo, with their contents, as you can on the ground.

### Screenshots

_No response_

### Versions and configuration

Win 10 tiles, 013e053 , magiclysm.

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Reproduce the movement described with a spillable container such as the Cauldron of Purification, powdered eggs, and cargo storage, then trace the item-transfer and message-handling entry points involved. Done means the behavior is either supported consistently with ground placement or warns about spillage and accurately reports which items enter storage and the inventory.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.