CleverRaven / CleverRaven/Cataclysm-DDA

map::saven grid (0,0,0) uninitialized! when placing "unexplored" via overmap editor

Open
#59,142 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

(P4 - Low) <Bug> Code: Debug Map / Mapgen Mechanics: Map Memory
Dominant language
C++
Stars
13.2k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

Describe the bug
 DEBUG    : map::saven grid (0,0,0) uninitialized!

 FUNCTION : void map::saven(const tripoint&)
 FILE     : src/map.cpp
 LINE     : 7172
 VERSION  : 0.F-9626-g5d5d5bd53b0

This repeats a couple of times due to the changing coordinates.

Steps to reproduce
  1. Enter the debug menu > (m)ap > (M)ap editor
  2. Press o to access the overmapgen editor.
  3. Place "unexplored" (right at the top, number 5).
  4. You get the error.
Expected behavior

No error. Using low priority for this issue because this is obviously not something that a normal player will ever reach.
This might even be a wontfix but no idea since I just randomly tried that and figured it might make sense to report this.

Screenshots

No response

Versions and configuration
  • OS: Linux
    • OS Version: LSB Version: n/a; Distributor ID: Arch; Description: Arch Linux; Release: rolling; Codename: n/a;
  • Game Version: 0.F-9626-g5d5d5bd53b0 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]
Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/map.cpp at map::saven(const tripoint&) around line 7172, then reproduce the issue through the debug map editor and overmapgen editor by placing "unexplored." Trace why saving the changed coordinates reaches an uninitialized grid, and consider the issue done when that action no longer emits the error.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.