CleverRaven / CleverRaven/Cataclysm-DDA

Riding on a bicycle from the roof (don't ask) leaves you floating in the air

Open
#57,720 5 comments 6 reactions 0 assignees View on GitHub
<Bug> Vehicles
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
1d 21h
Merged PRs (30d)
185

Description

### Describe the bug

Aside from what's in the title, bicycle is placed underground, not on the ground.

### Steps to reproduce

1. Somehow get a bicycle on the roof of some building.
2. Additional: put your trusty dog in a wire basket - in the name of the science, of course!
3. Make a clear path by smashing the gutters (if applicable).
4. Ride the bicycle and move to the edge of the roof and beyond.
5. Observe bicycle has fallen down to -1 z-level (the soil level), and that bicycle is mostly undamaged.
6. Observe you're floating in the air, despite message log says `You fell down a ledge!`.
7. Observe your trusty dog has fallen too.

### Expected behavior

1. Bicycle should fall down to the ground level, like all other vehicles do (at least when I tested the same situation with a car, it correctly landed down on ground level).
2. Bicycle should take "normal" damage from the falling, like all other vehicle do.
3. Player character should fall down too.

### Screenshots

Starting disposition
![изображение](https://user-images.githubusercontent.com/11132525/168463428-6de3ce8b-eeff-4961-8e56-a111a134d5f4.png)

After my bicycle (and my dog) has fallen down
![изображение](https://user-images.githubusercontent.com/11132525/168463501-b8938ccd-7e28-4be1-beba-85a3a4dc7646.png)

Location of bicycle
![изображение](https://user-images.githubusercontent.com/11132525/168463510-f8448c53-5593-4d95-8c83-786720b614b4.png)

### Versions and configuration

Windows 10 x64, 0.F-8389.

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

No source files or tests are named in the issue. Reproduce the roof-to-ground bicycle scenario, then compare the bicycle result with the reported car behavior; done means the bicycle, rider, and dog reach the ground level and the bicycle receives normal fall damage.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.