CleverRaven / CleverRaven/Cataclysm-DDA

CTD/Freeze hard to narrow down issue

Open
#54,847 6 comments 0 reactions 0 assignees View on GitHub
(S1 - Need confirmation) <Crash / Freeze>
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
200

Description

### Describe the bug

Depending on the rate of item spawning, I'm getting either a ctd, or game freeze that I can't alt-tab out of when approaching npcs shooting other npcs.

### Steps to reproduce

Play the game with the valk mod from, say, two weeks ago.
Update
Have global item spawn at .75
Approach a battlefield.
NPCs shoot at each other, (maybe do something with pockets?), and the game crashes.
Restart/Reload
Have global item spawn at 2.0
Approach a battlefield.
NPCs shoot at each other, game hangs, no alt-tab, no crash report.

Note: I was on a 5 day old version before I just updated, however those crash logs got overwritten by the newest crash logs, so I can't provide any evidence, easily, as such.

### Expected behavior

Usually I get get debug or crash logs enough to fix the mods that break, but this time I just get nothing, and I'd like to not throw away my world, again.

### Screenshots

_No response_

### Versions and configuration

Win 10 tiles, 761fb51,
Large save file, 185MB
Valk Mod, any visible debug errors fixed.

### Additional context

[crash.log](https://github.com/CleverRaven/Cataclysm-DDA/files/7953922/crash.log)

From a message I sent on the discord, the highest readable issue on the previous crash trace(s) were item_pocket::is_type(item_pocket::pocket_type)
My only guess is that increasing the item spawning is overloading pockets, somehow?

Ah, I was able to repro it with the item_pocket error, just required a 0.01 item spawn rate.
[crash0.01.log](https://github.com/CleverRaven/Cataclysm-DDA/files/7953986/crash0.01.log)

Contributor guide

Open the contributing guide

Research direction

No source file is named; start by comparing crash.log and crash0.01.log and tracing item_pocket::is_type(item_pocket::pocket_type) during the listed battlefield reproduction. Confirm whether the freeze or CTD is reproducible with the Valk mod and stated spawn rates; done means identifying the cause and validating a fix or clearer diagnostic.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.