CleverRaven / CleverRaven/Cataclysm-DDA

"Magic door" trap sometimes teleports player into a wall

Open
#54,584 0 comments 0 reactions 0 assignees View on GitHub
(S2 - Confirmed) Fields / Furniture / Terrain / Traps Mechanics: Enchantments / Spells
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
200

Description

### Describe the bug

Stepping on the "magic door" trap in the magic basement sometimes teleports the player from "Location x:y in a:b, basement" to "Location x:y in (a - 1):(b - 1), basement"

### Steps to reproduce

may take multiple attempts (from my testing it seems to only happen with certain rotations of the basement)
1. find a magic basement (or start a new character with the "wizard apprentice" start)
2. move the coatrack and step on the trap tile
3. be teleported

### Expected behavior

Player's position shouldn't change.

### Screenshots

example1 this time only the later variable (b) changed
![image](https://user-images.githubusercontent.com/93795131/150220496-82cbc8bd-0c5d-4ad9-9a1b-74facdd7e239.png)
![image](https://user-images.githubusercontent.com/93795131/150220665-02fc0a0f-9cdf-4804-b0be-d29cc2cee146.png)
example2
![image](https://user-images.githubusercontent.com/93795131/150221232-05a0be6a-79f4-476e-875e-811782126a80.png)
![image](https://user-images.githubusercontent.com/93795131/150221385-3a0cf185-52a0-4c10-81ba-e1ee2e430e33.png)

### Versions and configuration

- OS: Windows
- OS Version: 10.0 2009
- Game Version: d740104 [64-bit]
- Graphics Version: Tiles
- Game Language: English [en]
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Bionic Professions [package_bionic_professions],
Graphical Overmap [Graphical_Overmap],
Stats Through Skills [StatsThroughSkills],
Stats Through Kills [stats_through_kills],
Mythical Martial Arts [MMA],
SpeedyDex [speedydex],
Magiclysm [magiclysm],
Graphical Overmap Magiclysm [Graphical_Overmap_Magiclysm],
C.R.I.T Expansion Mod [crt_expansion],
Blaze Industries [blazeindustries]
]

### Additional context

May be related to #51694 I have no idea.

Contributor guide

Open the contributing guide

Research direction

Reproduce the issue in a magic basement using the wizard apprentice start, move the coatrack, and step on the trap across different basement rotations. Compare the behavior with related issue #51694; done means the player's position remains unchanged after triggering the magic door trap.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.