CleverRaven / CleverRaven/Cataclysm-DDA

[Magiclysm] Wolfshead Cufflinks changes stats permanently

Open
#54,343 5 comments 0 reactions 0 assignees View on GitHub
(S2 - Confirmed) Mods: Magiclysm
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
1d 23h
Merged PRs (30d)
186

Description

### Describe the bug

The activation of Wolfshead cufflinks changes the Strength stat by +2 and intelligence stat by -3 after the werewolf aura wears off.

### Steps to reproduce

1. Acquire "pair of wolfshead cufflinks"
2. wear and activate the cufflinks
3. Wait for aura to wear off
4. Note permanent change in stats

### Expected behavior

I expected the aura to only change the stats temporarily, but after waiting out the duration, some stat changes became permanent.

### Screenshots

![image](https://user-images.githubusercontent.com/36860546/149248106-c7399843-9c5e-42be-83df-b362384cb8a8.png)
![image](https://user-images.githubusercontent.com/36860546/149248217-b580d9c0-5851-4478-8f44-f7816c1e9681.png)
![image](https://user-images.githubusercontent.com/36860546/149248866-382d3baf-9082-4c01-8c9c-d02456aa65c7.png)

### Versions and configuration

- OS: Windows
- OS Version: 10.0 2009
- Game Version: 600018f [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Bionic Professions [package_bionic_professions],
Aftershock [aftershock],
Blaze Industries [blazeindustries],
C.R.I.T Expansion Mod [crt_expansion],
Magiclysm [magiclysm],
DinoMod [DinoMod],
Mythical Martial Arts [MMA],
Graphical Overmap [Graphical_Overmap],
Graphical Overmap Magiclysm [Graphical_Overmap_Magiclysm],
Bionic Slots [cbm_slots],
Stats Through Kills [stats_through_kills],
SpeedyDex [speedydex]
]

### Additional context

I already have a probable cause, The aura_werewolf is the only item so far that seems to give the player temporary mutations with inherent changes to stats (Apex Predator[PRED4], Large[LARGE_OK]), the mutations seem to align with the permanent stat changes and I assume it doesn't return the stats when the mutations are removed.

If I'm correct than I'm not real certain of a good fix besides removing those mutations from what is given.

Contributor guide

Open the contributing guide

Research direction

Start by reproducing the issue with the Wolfshead cufflinks, then trace the aura_werewolf effect and the temporary mutation removal path, especially mutations with inherent stat changes such as Apex Predator and Large. Done means Strength and intelligence return to their pre-activation values after the aura wears off, with regression coverage if the existing test structure supports it.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.