CleverRaven / CleverRaven/Cataclysm-DDA
Weapon damaged during a missed attack
- Dominant language
- C++
- Stars
- 13.1k
- Forks
- 4.6k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 200
Description
### Describe the bug
"You swing wildly and miss" and "The weapon is damaged by the force of the blow" contradict each other. If you dont hit anything, there is no "force of the blow".
### Steps to reproduce
1. Get a melee weapon
2. Get into some fights
3. Get "lucky"
### Expected behavior
Weapons should only ever be damaged when they hit something.
### Screenshots
_No response_
### Versions and configuration
- OS: Linux
- OS Version: Distributor ID: Ubuntu; Description: Ubuntu 20.04.3 LTS; Release: 20.04; Codename: focal;
- Game Version: 0.F-4363-g8b7a449e97 [64-bit]
- Graphics Version: Tiles
- Game Language: English [en]
- Mods loaded: [
Dark Days Ahead [dda],
Bionic Professions [package_bionic_professions],
Blaze Industries [blazeindustries],
C.R.I.T Expansion Mod [crt_expansion],
No Hope [no_hope],
Extra Mutated Scenarios [extra_mut_scens],
No Rail Stations [No_Rail_Stations],
No Fungal Growth [no_fungal_growth],
Bionic Slots [cbm_slots],
SpeedyDex [speedydex],
Stats Through Kills [stats_through_kills]
]
### Additional context
_No response_
Contributor guide
Research direction
Reproduce the issue with a melee weapon and a missed attack, using the listed game version and configuration as a reference. Trace the existing weapon-damage handling for missed attacks and add or update the relevant test if one is found. Done means a weapon is damaged only when the attack hits something.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100