CleverRaven / CleverRaven/Cataclysm-DDA

Copy-from doesn't copy cooking requirements for recipes

Open
#53,334 0 comments 0 reactions 0 assignees View on GitHub
<Bug> Crafting / Construction / Recipes
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

### Describe the bug

For cooking recipes, copy-from doesn't copy cooking requirements ("qualities" and "tools") from its source recipe.

### Steps to reproduce

1. Open data/json/recipes/food/offal_dishes.json
2. Delete lines 23-24 ("qualities" and "tools" for mutant_brain_cooked)
3. Open C:DDA and check the recipe for cooked mutant brains
4. Cooking requirements no longer there despite the recipe copying from one that had cooking requirements

### Expected behavior

The function should copy cooking requirements from the source recipe.

### Screenshots

_No response_

### Versions and configuration

- OS: Windows 10
- Game version: 40e9432
- Graphics version: Tiles
- Ingame language: English
- Mods loaded: dda, no_npc_food, package_bionic_professions, cbm_slots, No_Rail_Stations

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with data/json/recipes/food/offal_dishes.json and reproduce the issue by removing the qualities and tools from mutant_brain_cooked. Trace the recipe copy-from handling and verify that those cooking requirements are inherited from the source recipe. Done means the cooked mutant brains recipe retains both requirements after copying.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.