CleverRaven / CleverRaven/Cataclysm-DDA

NPC stuck in continuous loop searching for a tool.

Open
#52,283 3 comments 0 reactions 0 assignees View on GitHub
(S2 - Confirmed) NPC / Factions
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
200

Description

### Describe the bug

My NPC is working on furniture deconstruction by the light of my lamp. My headlight battery died and so the NPC could no longer see to work. I got confusing messages about my NPC finishing her work, then dropping a hammer on the long grass (she was deconstructing inside, so maybe she went outside to start a different task? But why would she be using a hammer?), then a message that my NPC dropped her screwdriver on the floor, and when I decided to go out to replace my battery everything stopped. It wasn't a crash, just incredible lag (the keyboard backlog sent me walking right out the door into the woods). I then got a message that the NPC was looking for a tool (x400) and then another of the same (x800).

### Steps To Reproduce

1. open save file.
2. try to take a step.

### Expected behavior

NPC should move on to next task on fail.

### Screenshots

![Screenshot_in_game_msgs](https://user-images.githubusercontent.com/64863108/137228014-24d3f96a-6370-496f-b068-b7c55a6033f1.png)

### Versions and configuration

- OS: Linux
- OS Version: Distributor ID: Ubuntu; Description: Ubuntu 20.04.3 LTS; Release: 20.04; Codename: focal;
- Game Version: 0.F-3357-g95019f2a75 [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
No Fungal Growth [no_fungal_growth],
Bionic Professions [package_bionic_professions]
]

### Additional context

After the bug showed up, I copied the save folder that continues the behavior, pulled updates from git, recompiled, opened the original save file (not the copy) and the lag continued.

Sorry - The game report above was produced AFTER updating and recompiling (gcc). I didn't know to generate a game report for original game version that created the bug. The original version, the one which produced the save file I am sending, was 0.F-3331-g825605829f (copied by hand off the start screen)
[Alexbug.zip](https://github.com/CleverRaven/Cataclysm-DDA/files/7341986/Alexbug.zip)
.

Contributor guide

Open the contributing guide

Research direction

Start with the attached Alexbug.zip save and reproduce the NPC's repeated tool-search messages after the headlight battery dies. Trace the NPC task handling that follows failed furniture deconstruction and tool lookup. Done means the NPC abandons the failed task and moves to the next task without entering a continuous loop or causing severe lag.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.