CleverRaven / CleverRaven/Cataclysm-DDA
Having a whistle multitool breaks the %-f menu action ("start a fire quickly") inconsistently.
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 13.2k
- Forks
- 4.6k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 205
Description
### Describe the bug
The whistle multitool is a combination whistle, thermometer, and magnifying glass. However, having it on your person seems to prevent you from being able to use the "start a fire quickly" Item Menu Action in an inconsistent fashion. According to some combination of rules that I do not understand, having one on you will prevent you from using the item menu action "start a fire quickly" most of the time. It will be greyed out in the menu, and if you press the hotkey (assuming it's not bound to something else) the game will pop out a message box telling you that you do not have an item that can do that.
Unless, sometimes, you just picked up the whistle multitool, then things will work again. Sometimes. I can't discern a pattern. Curiously, it will never break the camp fire drill for some reason.
### Steps To Reproduce
1. Give a character a whistle multitool and any other fire starting item, except the camp fire drill. I tested a bunch of things, but I first noticed the problem with a disposable lighter.
2. Make sure the weather is sunny or clear.
3. Use the Item Action Menu (default key %) and attempt to "start a fire quickly" (default key "f"). Note that the menu item is greyed out and pressing the hotkey anyways will tell you that you cannot do this.
4. Get the whistle multitool out of your inventory. Just dropping it at your feet will work.
5. Attempt to "start a fire quickly" from the item action menu. It should work (or at least, tell you that you there is no fuel on the tile you selected).
6. Pick up the whistle multitool. Try to start a fire quickly again. See that you cannot use the lighter to do this. Unless you can, using some combination of actions that I cannot consistently replicate.
7. Try with other fire starting tools if you like. My full list is as follows: Lit candle, lit ember carrier, refillable lighter, magnifying glass, reading glasses, fire drill, camp fire drill (again, the only tool that doesn't seem to be broken by this bug).
8. While in a bugged state, try it with cloudy weather, or at night, and see that it is still bugged.
9. While in a bugged state, wield a fire starting item, and see that the item action menu "start a fire quickly" option works again, with the wielded item. Un-wield that item, and see the bugged behavior return.
### Expected behavior
Ability to set fires wherever and whenever I please, according to my whims and with the multitude of tools at my disposal.
### Screenshots
_No response_
### Versions and configuration
- OS: Windows
- OS Version: 10.0 2009
- Game Version: 8256058 [64-bit] (experimental build 2021-10-11-0810)
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
No Fungal Growth [no_fungal_growth],
Bionic Professions [package_bionic_professions]
]
### Additional context
_No response_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue through the Item Action Menu using a whistle multitool with the listed fire-starting items, then compare the "start a fire quickly" behavior before and after dropping or wielding items. Trace the implementation of that action and its item eligibility checks, including the camp fire drill exception; done means eligible tools work consistently while the whistle multitool is carried, with regression coverage for the reported cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- game-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100