CleverRaven / CleverRaven/Cataclysm-DDA

[0.F stable] Companions bugged after quest fulfillment

Open
#50,846 1 comment 0 reactions 0 assignees View on GitHub
<Bug> Missions NPC / Factions
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
200

Description

### Describe the bug

After simultaneously fulfilling two companion quests to retrieve info from a bank vault and getting their next quests (get deputy badges), I saved the game, and after that both of them are bugged in that neither of them follow the PC anymore, and one of them has the dialog corrupted. The corruption is that after saying their quest hasn't been fulfilled yet, the next dialog only provides a "bye" option, rather than the normal continuation to the regular dialog options.

### Steps To Reproduce

Fulfill two "get info from bank safe" quests simultaneously in the same vault?

### Expected behavior

The companions would continue to function as normal.

### Screenshots

_No response_

### Versions and configuration

- OS: Windows
- OS Version: 10.0 2009
- Game Version: bc28921 [64-bit]
- Graphics Version: Tiles
- Game Language: System language []
- Mods loaded: [
Dark Days Ahead [dda],
Disable NPC Needs [no_npc_food],
Bionic Professions [package_bionic_professions]
]

### Additional context

I saved the game standing outside the vault, entered and fulfilled the first companion's quest, killed the game and reloaded, this time activating the second companion's quest (I was afraid only one safe would be inside, blocking the second quest), opened the value again, found two safes, picked them both up and fulfilled both quests and continued to activate their next quest (deputy badges), after which I saved again.
When trying to leave the bank I found them failing to follow the PC, so I tried to change their following distance to try to jiggle them out of it, at which time I found that dialog of one of them had been bugged so that was no longer possible.

The issue may or may not have a similar cause to the bugged dialog for Dana of the refugee center, who only provides a "Hello, I've got to leave" option.

[Auburn Hills - Copy (5).zip](https://github.com/CleverRaven/Cataclysm-DDA/files/6998621/Auburn.Hills.-.Copy.5.zip)

Contributor guide

Open the contributing guide

Research direction

Load the attached Auburn Hills save and reproduce the failure by completing both companion vault quests, reloading, and accepting the deputy-badge quests. Investigate the companion following and dialogue state after quest fulfillment and save/reload; done means both companions follow normally and their dialogue returns to the regular options.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.