CleverRaven / CleverRaven/Cataclysm-DDA

Basecamp mission "Setup Hide Site" aborts with "you need equipment" message

Open
#49,999 1 comment 0 reactions 0 assignees View on GitHub
<Bug> Missions
Dominant language
C++
Stars
13.1k
Forks
4.6k
Avg merge
2d 1h
Merged PRs (30d)
205

Description

### Describe the bug

I haven't found a way to use this mission successfully.
Looking at the code in faction_camp.cpp (around line 1997) it appears that the game checks your inventory, excluding any items that can revive:
```
inventory tgt_inv = *get_player_character().inv;
std::vector pos_inv = tgt_inv.items_with( []( const item & itm ) {
return !itm.can_revive();
} );
```
Then if the resulting pos_inv is not empty, you are supposed to be offered an option to give your companion additional items and then choose who to send. If it is empty, the game throws a popup "you need equipment" and aborts.

Trouble is, my inventory is definitely not empty and yet I'm getting a "you need equipment" popup. Could it be that major inventory updates since the implementation of this code have made it unusable?

If anyone successfully used this mission, feel free to tell me I'm wrong. However, even in such a case, the popup is extremely unclear on why the mission cannot start.

### Steps To Reproduce

1) Load attached save (New England > Norman Freeman).
2) Interact with bulletin board adjacent to the PC.
3) Select Setup Hide Site, choose any forest location. Observe the popup message.
[New England.zip](https://github.com/CleverRaven/Cataclysm-DDA/files/6834300/New.England.zip)

### Expected behavior

Expected to get the option to give gear, then choose companion and the mission should start.

### Screenshots

_No response_

### Versions and configuration

Terminal, Ubuntu 18.04, experimental 0.F (9658f3d in main menu).
Default mods + Stats Through Kills.

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with faction_camp.cpp around line 1997 and reproduce the failure using the attached New England save, following the bulletin-board steps. Check the inventory filtering and the "you need equipment" path against the expected gear-giving and companion-selection flow. Done means the mission starts as expected or the popup clearly explains why it cannot.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
game-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.